Matija Koželj koma
0 Followers · 0 Following
  • Joined on 2022-11-30
Repositories Projects Packages Public Activity Starred Repositories
1
koma pushed to features/rewrite/styles at Connected/Connected.Components 2023-02-17 09:47:54 +00:00
31be47fb6a Merge branch 'features/rewrite/styles' of https://git.tompit.com/Connected/Connected.Components into features/rewrite/styles
42d67dee07 Merge pull request 'Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class' (#8) from features/rewrite/checkbox into features/rewrite/main
7c60aefe31 SimpleSelect - code cleanup (removed unnecessary blank space, removed unused private methods)
d688b25589 Radio, RadioGroup
a90cf518a3 Fixes for InputAttributes in SimpleSelect
Compare 6 commits »
koma pushed to features/rewrite/main at Connected/Connected.Components 2023-02-17 09:46:20 +00:00
42d67dee07 Merge pull request 'Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class' (#8) from features/rewrite/checkbox into features/rewrite/main
7c60aefe31 SimpleSelect - code cleanup (removed unnecessary blank space, removed unused private methods)
d688b25589 Radio, RadioGroup
a90cf518a3 Fixes for InputAttributes in SimpleSelect
e83e46abc0 Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class
Compare 5 commits »
koma merged pull request Connected/Connected.Components#8 2023-02-17 09:46:19 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class
koma pushed to features/rewrite/styles at Connected/Connected.Components 2023-02-17 09:34:52 +00:00
cac80598f0 Clear remaining nuget package traces
koma pushed to features/rewrite/main at Connected/Connected.Components 2023-02-17 09:34:25 +00:00
cac80598f0 Clear remaining nuget package traces
koma suggested changes for Connected/Connected.Components#8 2023-02-16 14:58:53 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class

Pull request contains changes of several components and some styling issues. Some are commented, and as the repeat, please see me for corrections before continuing work.

koma commented on pull request Connected/Connected.Components#8 2023-02-16 14:58:53 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class

Nested ifs should be joined in single condition, especially if all are single-lined.

koma commented on pull request Connected/Connected.Components#8 2023-02-16 14:58:53 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class

See here

koma commented on pull request Connected/Connected.Components#8 2023-02-16 14:58:53 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class

Should probably be null if uninitialized. Minor detail.

koma commented on pull request Connected/Connected.Components#8 2023-02-16 14:58:53 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class

Single line if statements should be braceless, but not inlined, e.g.

koma commented on pull request Connected/Connected.Components#8 2023-02-16 14:58:53 +00:00
Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class

The line contains an invisible Unicode character that should definitely not be there.

koma pushed to develop at Connected/Connected.Framework 2023-02-15 16:35:19 +00:00
79ea6dc46d Add dependency on Connected repo
db50455545 Add test projects for resolved code
ba619605b9 Merge branch 'features/nuget_autobuild' of https://git.tompit.com/Connected/Connected.Framework into features/nuget_autobuild
6b4fa3d63b AsUrlFriendly extension added
43312c3362 AsUrlFriendly extension added
Compare 93 commits »
koma deleted branch features/updateMerge from Connected/Connected 2023-02-15 15:28:56 +00:00
koma pushed to develop at Connected/Connected 2023-02-15 15:28:55 +00:00
9eb9949950 Merge pull request 'features/updateMerge' (#8) from features/updateMerge into develop
0ce199e5ee Merge branch 'features/nuget_autobuild' into develop
eb1e4af29f Replace DefaultLayout styles with component styles
c38549a17e Move IConfigurationService from CoreStartup to ClientStartup
9388dcbcc5 Add IConfigurationService to core startup
Compare 31 commits »
koma merged pull request Connected/Connected#8 2023-02-15 15:28:55 +00:00
features/updateMerge
koma created pull request Connected/Connected#8 2023-02-15 15:28:50 +00:00
features/updateMerge
koma created branch features/updateMerge in Connected/Connected 2023-02-15 15:26:42 +00:00
koma pushed to features/updateMerge at Connected/Connected 2023-02-15 15:26:42 +00:00
0ce199e5ee Merge branch 'features/nuget_autobuild' into develop
koma deleted branch features/projectCleanup from Connected/Connected 2023-02-15 14:40:45 +00:00
koma pushed to develop at Connected/Connected 2023-02-15 14:40:45 +00:00
1ae6f4d8a6 Merge pull request 'Clean project files' (#7) from features/projectCleanup into develop
405ecb2973 Clean project files
Compare 2 commits »