Connected/Connected.Components
14
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Checkbox - working example -- NumberInput,TextInput - InputAttributes initialization moved to InputBase class #8

Merged
koma merged 4 commits from features/rewrite/checkbox into features/rewrite/main 2023-02-17 09:46:19 +00:00
Conversation 1 Commits 4 Files Changed 14 +169 -44
stm commented 2023-02-16 09:57:53 +00:00
Member
Copy Link

Checkbox

Checkbox
koma was assigned by stm 2023-02-16 09:57:53 +00:00
stm added 1 commit 2023-02-16 09:57:54 +00:00
stm added 1 commit 2023-02-16 10:32:57 +00:00
stm added 1 commit 2023-02-16 12:18:20 +00:00
stm added 1 commit 2023-02-16 13:27:18 +00:00
koma requested changes 2023-02-16 14:58:53 +00:00
koma left a comment
Owner
Copy Link

Pull request contains changes of several components and some styling issues. Some are commented, and as the repeat, please see me for corrections before continuing work.

Pull request contains changes of several components and some styling issues. Some are commented, and as the repeat, please see me for corrections before continuing work.
src/Connected.Components/Components/TextInput.razor.cs
@ -63,0 +59,4 @@
protected override async Task OnInitializedAsync()
{
await base.OnInitializedAsync();
if (Required)
koma commented 2023-02-16 14:57:04 +00:00
Owner
Copy Link

Nested ifs should be joined in single condition, especially if all are single-lined.

Nested ifs should be joined in single condition, especially if all are single-lined.
src/Connected.Components/Components/TextInput.razor.cs
@ -63,2 +62,3 @@
if (Required)
{
if (base.InputAttributes.ContainsKey("required")) base.InputAttributes.Add("required", true);
if (!InputAttributes.ContainsKey("required")) InputAttributes.Add("required", true);
koma commented 2023-02-16 14:54:18 +00:00
Owner
Copy Link

See here

See [here](https://git.tompit.com/Connected/Connected.Components/pulls/8/files#issuecomment-141)
src/Connected.Components/Models/InputBase.cs
@ -1,7 +1,5 @@
using Connected.Utilities;
koma commented 2023-02-16 14:51:15 +00:00
Owner
Copy Link

The line contains an invisible Unicode character that should definitely not be there.

The line contains an invisible Unicode character that should definitely not be there.
src/Connected.Components/Models/InputBase.cs
@ -124,4 +122,9 @@ public class InputBase : ComponentBase
[Parameter]
public string Placeholder { get; set; } = string.Empty;
koma commented 2023-02-16 14:53:28 +00:00
Owner
Copy Link

Should probably be null if uninitialized. Minor detail.

Should probably be null if uninitialized. Minor detail.
src/Connected.Components/Models/InputBase.cs
@ -127,0 +125,4 @@
protected override async Task OnInitializedAsync()
{
if (InputAttributes is null) InputAttributes = new();
koma commented 2023-02-16 14:52:42 +00:00
Owner
Copy Link

Single line if statements should be braceless, but not inlined, e.g.

if(bool)
	DoSth();

instead of

if(bool) DoSth();
Single line if statements should be braceless, but not inlined, e.g. ``` if(bool) DoSth(); ``` instead of ``` if(bool) DoSth(); ```
koma merged commit 42d67dee07 into features/rewrite/main 2023-02-17 09:46:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
koma
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dij hoa jel joj kam koma ocm pit sis skm sog stm vem wam
No Assignees koma
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Connected/Connected.Components#8
No description provided.
Delete Branch "features/rewrite/checkbox"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?